fix(incoming-task): fix-incoming-task-overflow-issue by akulakum · Pull Request #482 · webex/widgets

akulakum · 2025-06-30T12:05:40Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6598

Vidcast link: https://app.vidcast.io/share/fd9dc8bf-91ac-4b30-8fc1-0e744ac552c3

This pull request addresses

This pull request addresses the issue of overflowing content in multiple widgets when handling long email addresses as the media type. Specifically:

1. Context of the Issue:

In the Incoming Task Widget rendered in toast notifications, when the media type is email and the user's email address is long, the following problems occur:

The email icon overflows outside of the container.
The email text does not wrap or display an ellipsis, causing layout issues.

This issue is not limited to the Incoming Task Widget but is also present in the Call Control Widget and the Task List Widget.

2. Fixes Provided:

The overflow issue has been resolved in the Incoming Task Widget, ensuring:

The email icon stays within the container.
Long text is properly truncated using ellipsis.
A tooltip is shown for digital tasks (e.g., email, chat) to view the full content.
No tooltip is shown for voice-related tasks.

Similar fixes have been implemented in the Call Control Widget and Task List Widget to maintain consistency and resolve the same issue across all affected components.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document

coderabbitai · 2025-06-30T12:05:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-06-30T12:10:36Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-482.d1b38q61t1z947.amplifyapp.com

…RRIDE_STYLE_ISSUE

mkesavan13

Let's run this through UX to know if we should word wrap or add ellipsis and a tooltip everywhere

mkesavan13 · 2025-07-01T05:40:57Z

+
+.customer-name::part(text),
+.phone-number::part(text) {
+  white-space: normal !important;


Can we not have the !important tag instead increase the CSS Specificity?

mkesavan13

Looks good to me. Thanks, Akula :-)

adhmenon

Overall LGTM. Just one question about the custom stles

adhmenon · 2025-07-03T13:37:46Z

    color: var(--mds-color-theme-indicator-secure);
  }
+}
+.call-control-task-tooltip::part(popover-content) {


Just curious - we are using custom styles here - UX is alright with the changes correct?

Yes, we are overriding the Momentum default styles here to enable text wrapping for the tooltip. UX has reviewed and is okay with these custom style changes.

# [1.28.0-ccwidgets.84](v1.28.0-ccwidgets.83...v1.28.0-ccwidgets.84) (2025-07-03) ### Bug Fixes * **incoming-task:** fix-incoming-task-overflow-issue ([#482](#482)) ([af70bee](af70bee))

sreenara · 2025-07-03T15:03:35Z

🎉 This PR is included in version 1.28.0-ccwidgets.84 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(incoming-task): fix-incoming-task-overflow-issue

66fa834

adhmenon added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 30, 2025

Merge branch 'ccwidgets' of github.com:webex/widgets into IC_TASK_OVE…

2828c54

…RRIDE_STYLE_ISSUE

mkesavan13 requested changes Jul 1, 2025

View reviewed changes

akulakum added 2 commits July 2, 2025 21:21

fix(incoming-task): fix-incoming-task-overflow-issue-using-ellipsis

2aec8c7

fix(incoming-task): removed-important-keyword-from-styles

17e76b4

mkesavan13 approved these changes Jul 3, 2025

View reviewed changes

Merge branch 'ccwidgets' into IC_TASK_OVERRIDE_STYLE_ISSUE

23aaa0a

adhmenon approved these changes Jul 3, 2025

View reviewed changes

mkesavan13 merged commit af70bee into webex:ccwidgets Jul 3, 2025
8 of 9 checks passed

sreenara added the released on @ccwidgets label Jul 3, 2025

Uh oh!

Conversation

akulakum commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6598

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

coderabbitai Bot commented Jun 30, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

aws-amplify-us-east-2 Bot commented Jun 30, 2025

Uh oh!

mkesavan13 left a comment

Choose a reason for hiding this comment

Uh oh!

mkesavan13 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

mkesavan13 left a comment

Choose a reason for hiding this comment

Uh oh!

adhmenon left a comment

Choose a reason for hiding this comment

Uh oh!

adhmenon Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

akulakum Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

akulakum commented Jun 30, 2025 •

edited

Loading